Bug (done?)

No version change when editing multiple items / #6596

Summary

done?
Jun 10, 2008
100%
Jun 10, 2008 / uweriehm
Nov 17, 2008 / pixtur
pixtur
 

Attached files

No files uploaded

Issue report

Minor
Always
0.0803
When marking multiple items (tasks) for editing and changing their "resolved in" version this change is not applied to the tasks selected.
I think there is a minor bug in task_more.inc.php
An else branch is missing as showed below. Without that else the resolved_version is set to 0 always regardless of the choosen version:
            ### resolve version ###
            $rv= get('task_resolved_version');

            if((!is_null($rv)) && ($rv != '__dont_change__') && ($task->resolved_version != $rv)) {
                if($rv && $rv != -1) {
                    if($v= Task::getVisibleById($rv)) {
                        if($v->isMilestoneOrVersion()) {
                            $task->resolved_version= $rv;
                            $change= true;
                        }
                    }
                    else {
                        continue;
                    }
                }
                else {                      <--- add this line
                if($rv == -1) {
                    $task->resolved_version= $rv;
                    $change= true;
                }
                else {
                    $task->resolved_version= 0;
                    $change= true;
                }
                }                        <--- add this line
            }
 

3 Comments

pixtur

Jun 11, 2008
thanks for the hint...
I will integrate the changes to the next version.

mrcase

Sep 3, 2008
Last open issue
That's the last open issue for the next milestone, can you do it pixtur?

pixtur

Oct 29, 2008
 

Comment / Update