Looked at your changes... / #2628

task_more.inc.php

• please do not use TAB characters

• Line 3044: please do not use camelCase for varibales.
  • $newTask better written as $task_new
• Line 3084: please leave spaces before and after "="
• Line 3104: maybe the Minor Title could be something like "edit"
• Line 3157: please use formatting characters out of translation text
  • __('- no assigned projects') -> `'- '. __('no projects')
• Line 3198: Not sure, but if you label this "no other projects" you would require some assoc. array to collect all projects ids already been added to the list?
• Why not just leave labels like "Company Projects" entirely, if there are none?
• when rendering Checkboxes in forms, please use "<label for="XXX">" to increase hit area
• Line 3244: Why do you use Form_customHTML instead of something like:
  • $form->add(new Form_checkbox('checkbox_id',"Label",$value)); ?

render_page.inc.php

• Line 490-503: This code should be added to a js-file (e.g. misc.js)
• Pleae do not use document get element by id, but $('label#new_project')

On labeling form fields...

• new_project -> new_project_id
• pub_level -> task_pub_level
• prio -> task_prio
• a.s.o.

• The new effort could use the created time of the new task as beginning time