create person item table / #2358

• Please refactor ListBlock.render_trow() and make a custom version for bookmark list
• I think there is too much orange in the pages. I suggest to only highlight new/updated items like it was done with the items changed since last logout. I don't think we need two highlight mechanisms, so the old check can be removed.
• I think the labeling is a little bit awkward right now. Maybe we could replace "not viewed" with something like "changed/new/updated".
• I added a new field to date_highlight_changes to Person. Together with the page function personAllItemsViewed this can be used to mark all items as viewed without flooding the item_person table. This should be initialized with "now" for new persons.
• Why do you add the double id to the book-mark list? I just don't understand what this should be good for.
• Why didn't you start a new file for the list_bookmarks?
• I renamed isViewedByUser($auth->cur_user) into nowViewedByUser()
  • note that $auth->cur_user is the default value for the function, so I removed it from all calls.
• Please do not use getCurTheme():

Monitoring items

Old highlight mechanism

• In renderDateHtml() I compared all dates with $auth->cur_user->last_logout. If the item was modified after the last_logout, the date was rendered with the class isNew (bold orange). Since most list featured a modified date column, this was sufficient.

from render/render_list.inc.php

            if( $obj->isChangedForUser() ) {
				echo "<tr class='$style isChanged'>";
            }
            else {
				echo "<tr class='$style'>";
            }
		}

from styles.css

    table#bookmarks tr.isChanged a {
       font-weight:bold;
       color:#800;
    }

Labeling

Double id

from render/render_list.inc.php

echo "<tr id={$this->id}_{$obj->id} class='$style not_viewed'>";

list_bookmarks.inc.php

Other things to do

• Rename "My bookmarks" to "Your bookmarks"
• Add pagefunction "bookmark"/"remove bookmark" to taskView, commentView

Ideas

• Bookmarks should be sorted in reversed creation order (latest Bookmark on top of the list)
• Please do not change add immediate Notification to the notification function. Start a new function like Notifier.sendMonitoredChange($item) {} This function could also include the query of all all persons, that monitored the item.

• I don't thing that sending the notification on unchanged items after login in is a good idea. because:
  1. We could highlight those items in the bookmark list of the user
  2. Sending the notification stuff takes time, and just after login is the worst point to let the user wait
  3. There already is a good place for this kind of information: The notification mail itself. I just would it implement like suggested in Monitor Task/Bugs:

  monitored by you [ignore all monitored]:
  - admin edited > adfjlkasdjf (to xyz)  [ignore]
  
  sleeping monitored items [ignore all sleeping]
  - task23423 (not touched since 34 days) [ignore]

• index.php?go=stopNotifyUnchanged&item=234
• index.php?go=stopNotifyAllUnchanged
• index.php?go=stopNotifyChange&item=234
• index.php?go=stopNotifyAllChange

• what is public function outputNotifcationForPersonTXT($person) for?

• after bookmarkEdit the comment is ignored
• added bookmark should always display itemMonitorEdit (or similar) Form

• on 1.: ok, then remove the outputNotifcationForPersonTXT function.
• on 2.: I don't think that there is something like an ignore list. It would simply..
  • remove the Bookmark or
  • disable reminder for a Bookmark
• on 3. Sorry. I was wrong. The column list_bookmarks is just fine

1. Multiple forms? (--> but how can the submit work?)
2. One form for all bookmarks? (--> like editTasksMultiple)