> > Idea (blocked)

efforts: adding a field "for billing" / "not for billing"


Sep 12, 2006
Sep 12, 2006 / binder
Jan 5, 2009 / phsouzacruz

Attached files

No files uploaded
In advance of further billing tasks, could we insert a field in an effort, which indicates, whether this effort has to be billed to the costumer or it was done without a bill?
It would help us a great deal making the bills until streber does it for us! ;)


guest:How do we mark an effort which has been billed?

11 years ago -

First of all, I must say this application is great, especially the use of WIKI to link information together.

I'm using Efforts function a lot to track my time, at the end of the month, I will consolidate all the time and bill customers accordingly, but I'd like to know, after the effort has been billed, do you change the status to "Balanced"? Or "Discounted"? I don't understand what these two status are for. Anyone?

guest:Just a guess...

11 years ago -

Balanced = Billed.
Discounted = Not Counted.

burger:Bad translation ...

11 years ago

I did the status feature at the effort page and I had to translate the status items from German to English.
And this translation is for sure not perfect.
Maybe someone has another translation suggestion?
At the moment it is translated like this:
  • "neu" => "new"
  • "offen" => "open"
  • "abgerechnet" => "discounted" (meaning: used in bill, but the bill is not payed by the customer yet)
  • "bezahlt" => "balanced" (meaning: used in bill and the bill is already payed by the customer)
  • "nicht abrechenbar" => "not chargeable" (meaning: cannot be part of a bill; e.g. internal effort)


11 years ago

Hi Burger,

do I get you right, in that you already added a new "status" "not chargeable". This would need the requested flag "for billing" redundant? Or did I miss something?

burger:Yes ...

11 years ago

... I added the status "not chargeable".

Is this okay?

pixtur:yeah, but...

11 years ago

...what about the flag 'for billing'. Do we still need this one, if there is a status with the same meaning?

burger:Where is this 'for billing' flag?

11 years ago

I think I don't understand the question. What 'billing'-flag do you mean?

pixtur:sorry. I must have been dumb...

11 years ago

I always thought that there is a flag in the effort definition. I just checked again and couldn't find it. So this was probably a first sign of a burn out :)

Forget my comments and add some streber credits to your account :)

burger:no problem ;)

11 years ago

pixtur:Some comments to your changes

11 years ago (6. update 11 years ago)

no tabs pleaseπ

There are a lot of changes with tab characters again. Please fix this.

comments as # pleaseπ

class_project.inc.php line 668. Please never use "//" for commenting!

class_task.inc.php line 178π

calculation is a weird label. I think planned_costs would be more descriptive. Giving this a comment like "# %% #" makes it even harder to understand :)

class_task line 794:π

$person should be replaced with $created_by. Also it should be initialized with NULL like it is done for modified_by. Or I just don't get your intention...

list_projects.inc.php line 253π

I think those lines where commented, because you cannot be sure that he filters should really be printed (e.g. it breaks csv export). Therefore I added it as a seperate block because the actual call of print_automatic().

person.inc.php line 20,21π

Please include files only where they are needed. list_projects and especially list_tasks.inc.php are big source files. Including them at the beginning for person.inc.php will slow down all person related pages, even it no tasks lists are displayed. Please move this lines to the beginning of the respective pageFunctions.

task_more.inc.php line 539:π

Forgotten a construction site?


also see:

you did quiet a lot of changes. I have to get rid of the conflicts and comment my stuff as well). It looks like you have gotten pretty familiar with the internals of streber now. Congratulations :)

As having the "more features role" I am always a little bit reluctant with company specific hacks like the "internal costs" stuff. I still do not believe that this is a good idea... Also — after sleeping over it — I thing that projViewEffort should stay clean and we should move the new stuff to a page called projViewEffortSummary.

The rest of your changes are excellent. Now stop using Tabs to get your A+ :)

Before committing any more stuff, wait until I committed my changes. Otherwise I will have to fix more conflicts. It should be done until 3p.m. (in 10 minutes).

pixtur:ok... just committed...

11 years ago

Maybe you can check my changes as well :)


11 years ago (2. update 11 years ago)

  1. new 'home': Empty page (expect of project list and functions). Is this on purpose?
  1. your task: I don't see only my tasks. At the 'all' filter I see a lot more tasks. Is this on purpose, because I'm an admin?
  1. tabs: Sorry again. I always forget not to use them. I use Dreamweaver and someone told me that I can change the tab sign to spaces. But I don't know where I can change it. Maybe you know??
  1. comments: Sorry, too. I hope it will never happen again.
  1. calculation: I will change it. And sorry for the comment. I only use it internally if I would like to mark something new what I maybe will change again. So sorry :-).
  1. class_task line 794: Sorry? Wrong line?
  1. list_projects.inc.php line 253: So change it back???
  1. person.inc.php line 20,21: Oh, sorry. I really didn't know this. I will change it.
  1. task_more.inc.php line 539: What do you mean exactelly?

Is it okay if I make my changes next week, because I have to leave now and I cannot do any changes for streber till next friday.
I'm sorry that I have to leave you alone with all the unfinished/incorrect stuff. Sorry!!!

pixtur:don't be scared...

11 years ago

Streber is supposed to be a fun project. I am really glad about all your work. It can wait until next week.

And at least I know have some time to figure out answers to your questions. :)