notice on persons? / #1837

1. Due the the user right model we cannot have items outside of projects. That keeps us from attaching items to persons, because we do not know, how to check visibility for them. (I am still looking for a solution of this problem).
2. Although there could be project-comments, why not create a new tasks? If we introduce a task category anyway (see task categories) it would provide the same functionality and much more. (e.g. you could turn it into a real task and assign it. You could book an effort on a telefon conference, etc.). I am not sure how to link it to a person though...

1. person/client calls
2. i open him via search
3. personView gives me the joice to "add new <<task>>" (or whatever we will call it?)
4. the next view is like the newtaskview, but there
   1. I can also assign the task to existing projects/folders which the person (who called) is assigned to or
   2. I can create on the fly a new project/folder to put the task in

• Yes, Note is a subtype of Task
  • sooner of later we should start with task categories but for now this works with a regular tasks as well. The only problem is, that normal tasks would be listed in the person's assigned tasks list.
• Your suggestions to creating new projects on the fly is soooo beautiful. I really love it. Now we have to find a common solution for "smart & interactive" forms:
  • We need a special "onChange" event handler that would be attached by jquery. But I am not sure where to put this. Maybe we could define a onLoad-functions-array in the html-header and later add new init-functions on the fly like:

from rough example

echo "<select id=bla> <option>1</option><option>1</option></select>";
echo "<script>streber_page.init_functions.append(function() {$('select#bla').onChange=function{ ... }}

• I like the See notes idea, although I am not sure how to distinguish notes from other tasks. Maybe we already should implement task categories for this?
• The "Show notes" list could look similar to the comment list, which fold/expand toggles. Since a "Note" is just a "Task" it already has the "view_collapsed" field which could be used for this.

task_more.inc.php

• please do not use TAB characters

• Line 3044: please do not use camelCase for varibales.
  • $newTask better written as $task_new
• Line 3084: please leave spaces before and after "="
• Line 3104: maybe the Minor Title could be something like "edit"
• Line 3157: please use formatting characters out of translation text
  • __('- no assigned projects') -> `'- '. __('no projects')
• Line 3198: Not sure, but if you label this "no other projects" you would require some assoc. array to collect all projects ids already been added to the list?
• Why not just leave labels like "Company Projects" entirely, if there are none?
• when rendering Checkboxes in forms, please use "<label for="XXX">" to increase hit area
• Line 3244: Why do you use Form_customHTML instead of something like:
  • $form->add(new Form_checkbox('checkbox_id',"Label",$value)); ?

render_page.inc.php

• Line 490-503: This code should be added to a js-file (e.g. misc.js)
• Pleae do not use document get element by id, but $('label#new_project')

On labeling form fields...

• new_project -> new_project_id
• pub_level -> task_pub_level
• prio -> task_prio
• a.s.o.

• The new effort could use the created time of the new task as beginning time

I cannot put my js-function at misc.js, because it doesn't work in there and I don't know why?!

from burger

• on 1st: This is a bug. From_checkbox should use the value parameter just a you suggested it.
• on 2nd: Arg... The array_flip-issue again... Urgs... We have to refactor this in the next release.
• on 3rd: I already adjusted you js-code to:

from misc.js

    $("body.taskNoteOnPersonEdit input#new_project").change(function(e)
    {
		$('#proj').toggle();
		$('#proj_list').toggle();
    });

• note on person > new project checkbox does not work