The code works as espected, but... / #1800

tune Labeling...

• Mit Benutzerkonto
• Andere Personen
• Mitarbeiter
• Ansprechpartner
• Gelöscht

• Those labels do not make clear, that the lists might display overlapping content. I am not sure how we can fix this.

avoid magic numbers

from db/class_person.inc.php

			{
				$str_perscat = "AND (pers.category BETWEEN 0 AND 5)";
			}
			else if($perscat == PCATEGORY_CONTACT) 
			{
				$str_perscat = "AND (pers.category BETWEEN 6 AND 9)";
			}

$str_perscat = "AND (pers.category BETWEEN " . PCATEGORY_EMPLOYEE . " AND ". PCATEGORY_EXEMPLOYEE

Counting

• I do not think we should could those categories steadily. I would suggest...
  • 0 - "undefined" (or "member"?)
  • 10 .. 19 employees
  • 20 .. 30 client staff
• This would make it easier to add in things we forgott later. Also it's no additional effort in implementation.